Bug 172 - Crops placement. (pumpkin in particular)
: Crops placement. (pumpkin in particular)
Status: CONFIRMED
Product: Legacy Haven
Classification: Unclassified
Component: Game
: unspecified
: PC Windows
: --- minor
Assigned To: loftar
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-09 22:17 CEST by MvGulik
Modified: 2013-05-11 21:21 CEST (History)
0 users

See Also:


Attachments
Pumpkin placement screeny (35.38 KB, image/png)
2013-05-10 11:35 CEST, MvGulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MvGulik 2013-05-09 22:17:21 CEST
It seems that the current crops placement is not taking in account any res-offset-data/values. Image placement seems solely linked to the bottom-center of the used crop-images. (so shadow image not included here.)

On most crops, that also are displayed using multiple images, and that have there visual center-point of the crop at the bottom of the crop image, there is no real problem.

But with the pumpkin, that is only using a single image to display the crop, and that has its visual crop-center point somewhere above the bottom of the image, it puts the pumpkin to high in relation to the tile its linked.

(... this can't be corrected by any res-modding, other than ditching some of the pumpkin bottom-image-lines. :( )
Comment 1 loftar 2013-05-10 06:12:15 CEST
While it is as you write, I must admit I don't quite see what the problem is. How is the pumpkin "too high"? In relation to what? What other placement are you suggesting would be more proper, and in what way?
Comment 2 MvGulik 2013-05-10 11:34:20 CEST
The pumpkin is kinda high(upwards,screen display) in relation to the tile it supposedly was planted in. Kinda making it drift from its intended/expected tile/location. This could be seen as only a minor display/offset issue.

The lack (so far as I know. see*) of not being able to lower the placement of the pumpkin(as test case) image is kinda a general crop-image limitation. Placing (unneeded) restrictions on the used image/drawing that can be used for the pumpkin, or other crops. (Res-Modders nightmare.)

Screen shot: (Taken from Vanilla client.)
Magenta: tile grid. (Based on Ender client.)
Light Blue: Tile related to nearest pumpkin above. (The pumping that is using that tile.)
Blue: Lowest* image line available for pumpkin gfx.
Yellow: Pumpkin(drawing) offset. (Offset of where it is, compared to where it is kinda expected to be. (different drawing different offset.)

*) Provided the 2 first of the 3 values I see in the code layer of the pumpkin res file are not location/offset related. I was not able not test that(**), so I don't know for sure. I figure the 3th value is the number of crop images to be used for displaying a given crop.)

**) Erm. I always forget to look a available source code. (haven.resutil.GrowingPlant.Factory).


Hope this clarifies my views on it a bit more and answered your questions.
Comment 3 MvGulik 2013-05-10 11:35:37 CEST
Created attachment 32 [details]
Pumpkin placement screeny
Comment 4 MvGulik 2013-05-11 21:21:10 CEST
Mmm. I must be overlooking/missing something. As the "Schematic plants(by Redraw)" res-mod seems to be doing what I thought as impossible.